Content
View differences
Updated by Parimal Satyal over 1 year ago
#### Context
In the context of changes made to polling in ##54733, the error message concerning conflicting modifications to a work package is particularly misleading. This is an effort to improve that.
#### Steps to reproduce
In the current production version of OpenProject (Community):
* User A enters edit mode of a work package (any field, not necessarily description)
* User A makes changes
* User B modifies the same work package in parallel
* User A tries to save the (unbenowst to them) now-stale work package
#### **Buggy behaviour**
* The user receives the following error, with a link to reload the page to load the updated version.
* However, if the user is still editing an attribute (eg. the description is in edit mode), the user (Parimal will still have the stale content for that attribute.
* The conflict is then not resolved.
<img class="image_resized op-uc-image op-uc-image_inline" style="width:663px;" src="/api/v3/attachments/234553/content"> complete)
#### **Expected behaviour**
* When a change is detected in the work package by another user or in another window (i.e., the work package is now "stale"): **Warning** (automatically appears)
* Automatically display a **warning message**.
* Use the existing Primerised Refresh banner, but in a warning yellow.
* Text: "This page has been updated by someone else. To not lose your edits, copy them locally and reload to view the updated version."
* Action: **Discard changes and reload**.
(Browser refresh)
* This triggers a browser refresh.
**Error:**
* If Supress the user, despite warning banner in favour of the warning, tries to save their changes:
error one.
* Display an **error message**. Red
* Use the existing a Primerised Refresh banner, in red. (If banner component (if possible, else use the existing Angular current one)
* Supress the warning banner in favour of the error one.
* Text: "Could not save your changes because of conflicting modifications. To not lose your edits, copy them locally and reload to view the updated version."
* Action: **Discard changes and reload** (Browser refresh)'
#### Reference
A reference of the Primerised Refresh banner:
<img class="image_resized op-uc-image op-uc-image_inline" style="width:843px;" src="/api/v3/attachments/234555/content">
####
**Notes**
* Known limitation: Some edits cannot really be copied, so the message doesn't work in all cases. It is nevertheless an improvement.
* This is a stop-gap solution to slightly improve on what already exists.
(Describe what happens now and why it's not good)
* We'll work on a better solution as a separate feature, perhaps:
* perhaps with diff-ing that allows users to better understand the conflict
* concurrent editing of _different_ attributes doesn't trigger the error
### Environment information
**Community**
OpenProject 14.6
**Browser:**
Firefox, Mac (desktop)
**Language**
EN diff-ing.
In the context of changes made to polling in ##54733, the error message concerning conflicting modifications to a work package is particularly misleading. This is an effort to improve that.
#### Steps to reproduce
In the current production version of OpenProject (Community):
* User A enters edit mode of a work package (any field, not necessarily description)
* User A makes changes
* User B modifies the same work package in parallel
* User A tries to save the (unbenowst to them) now-stale work package
#### **Buggy behaviour**
* The user receives the following error, with a link to reload the page to load the updated version.
* However, if the user is still editing an attribute (eg. the description is in edit mode), the user
* The conflict is then not resolved.
<img class="image_resized op-uc-image op-uc-image_inline" style="width:663px;" src="/api/v3/attachments/234553/content">
#### **Expected behaviour**
* When a change is detected in the work package by another user or in another window (i.e., the work package is now "stale"):
* Automatically display a **warning message**.
* Use the existing Primerised Refresh banner, but in a warning yellow.
* Use the existing
* Text: "Could not save your changes because of conflicting modifications. To not lose your edits, copy them locally and reload to view the updated version."
#### Reference
A reference of the Primerised Refresh banner:
<img class="image_resized op-uc-image op-uc-image_inline" style="width:843px;" src="/api/v3/attachments/234555/content">
####
* Known limitation: Some edits cannot really be copied, so the message doesn't work in all cases. It is nevertheless an improvement.
* This is a stop-gap solution to slightly improve on what already exists.
*
* concurrent editing of _different_ attributes doesn't trigger the error
### Environment information
**Community**
OpenProject 14.6
**Browser:**
Firefox, Mac (desktop)
**Language**
EN