Content
View differences
Updated by Henriette Darge about 2 years ago
We are facing some issues with the Primer Dialog which leads us to the question of whether we want to continue using it
### Biggest disadvantages
1. It is rendered per default in the DOM on page load. A click on the trigger only toggles the visibility. This will cause sooner or later performance problems, especially when we have multiple Dialogs on a page and the forms inside the Dialogs are complex (thinking of the Work Package page)
2. The rendered `top-layer` causes issues with other libraries as `ng-select` or `ckEditor`
1. ##53789
2. [https://github.com/opf/openproject/pull/14683](https://github.com/opf/openproject/pull/14683)
### Biggest advantages
1. It is a native Primer component and maintained as such
1. This also makes it easier to use it inside other Primer components (e.g. the PageHeader)
## Possible solutions
1. Do not use Primer Dialog, but our native Dialogs
2. Change the implementation of Primer Dialogs
3. For each issue, try to find a way around this
1. It is rendered per default in the DOM on page load. A click on the trigger only toggles the visibility. This will cause sooner or later performance problems, especially when we have multiple Dialogs on a page and the forms inside the Dialogs are complex (thinking of the Work Package page)
2. The rendered `top-layer` causes issues with other libraries as `ng-select` or `ckEditor`
1. ##53789
2. [https://github.com/opf/openproject/pull/14683](https://github.com/opf/openproject/pull/14683)
1. It is a native Primer component and maintained as such
1. This also makes it easier to use it inside other Primer components (e.g. the PageHeader)
## Possible solutions
1. Do not use Primer Dialog, but our native Dialogs
2. Change the implementation of Primer Dialogs
3. For each issue, try to find a way around this