Content
View differences
Updated by Henriette Darge almost 3 years ago
# Issues
* [ ] **Font prominence:** Reduce all font sizes 16px to 14px (Primer approach) or override with a font smoothing.
* [ ] Decisions: We try 14px. If we see it's too much work, we can still switch to the override tbd
* [ ] **Filter box and input fields:** Primer input fields are transparent. Therefore inside of the filter box they appear grey.
* [ ] Decisions: We propose to remove the box background in accordance to most of the boxes in Primer.
* [ ] **Input and select fields labels and values:** Everywhere in the app the labels and values of the input fields react differently (bold, non bold, text sizes, placeholder styles…) due to our current form implementation.
* [ ] Decision: tbd
* [ ] **Flashes:** Links in flashes are not highlighted as links
* [ ] Decisison: Show links as links again (For For example, new LDAP connection page) page
* [ ] **Toggle buttons:** the only buttons are bold are the toggle ones.
* [ ] **Toolbar actions:** some of the buttons in the toolbars have an underline hover.
* [ ] Decision: Since it is too much work to replace all links with actual button tags, we will override the hover effect very specificly (`.toolbar a.button`)
* [x] **Headers space:** after removing divider from the activity as they don’t use divider for headers some places have no spacing bellow.
* [x] Decision: No generic decision, needs to be decided case by case
* [ ] **Enterprise banners:** they are broken in spacings and sizes.
* [ ] Decision: There went something wrong with the html strucutre. Only the header should be bigger (20px), the rest should be 14px. Also the icons (e.g I don’t know if this is because of Primer or they are already broken in the "more information" link should be smaller) current development.
* [x] [ ] **News headers and body text:** reduce the size of this texts to make it less prominent.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x] [ ] **Roadmap spacings:** the space between one version and the next one seams to be reduced now that we don’t have a divider.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [ ] **User activity:** the page is difficult to read by itself but now without dividers is even worst.
* [ ] Decision: Remove custom styles of class `.op-activity-days--header` (Check for other occurences of this class)
* [ ] **Input and select fields labels and values:** Everywhere in the app the labels and values of the input fields react differently (bold, non bold, text sizes, placeholder styles…) due to our current form implementation.
* [ ] **Invite users:** the font weights in the process are wrong.
* [ ] **Toggle buttons:** the only buttons are bold are the toggle ones.
* [ ] Decision: The Spot classes will be changed, to ensure, that no label is bold. Either, we add the `.spot-selector-field--label_regular` to the html or change it in the SPOT CSS directly
* [ ] **Input fields with placeholders:** The placeholder text has the same colour as a normal value meaning the user can differentiate it
* [ ] Decision: Take care the placeholder values are shown like before (grey and cursive)
* [ ] **My account -> Notification settings:** not bold like in the majority of the places and wrong alignment (same happens with email reminders).
**Home**
* [ ] **User customised blocks (widgets):** The texts in widgets that are customised blocks are not taking the Primer styles correctly.
* [ ] Decision: user created contend should also have the base font size of 14px (\`var(--wiki-default-font-size\`)
* [ ] **Enterprise banners:** Clearly the text size and some icons are not correctly displayed.
* [ ] Decision: see above
**Board** # **Parts to test separatly**
* [ ] **Add new card**: Input is bold
Any Enterprise feature, team planners and boards are the most critical
* [ ] Decision: Should not be bold Nextcloud integration
* [ ] **Configure view**: Radio options are missing space and are bold
* [ ] Decision: `.option-label` should not be bold GitHub tab with linked PR
* [ ] **Font prominence:** Reduce all font sizes 16px to 14px (Primer approach) or override with a font smoothing.
* [ ] Decisions: We try 14px. If we see it's too much work, we can still switch to the override
* [ ] **Filter box and input fields:** Primer input fields are transparent. Therefore inside of the filter box they appear grey.
* [ ] Decisions: We propose to remove the box background in accordance to most of the boxes in Primer.
* [ ]
* [ ] Decision: tbd
* [ ]
* [ ] Decisison: Show links as links again (For
* [ ]
* [ ]
* [x] **Headers space:** after removing divider from the activity as they don’t use divider for headers some places have no spacing bellow.
* [x] Decision: No generic decision, needs to be decided case by case
* [ ] **Enterprise banners:** they are broken in spacings and sizes.
* [ ] Decision: There went something wrong with the html strucutre. Only the header should be bigger (20px), the rest should be 14px. Also the icons (e.g
* [x]
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x]
* [x] Decision: Ignore that, as the whole page needs a redesign
* [ ] **User activity:** the page is difficult to read by itself but now without dividers is even worst.
* [ ] Decision: Remove custom styles of class `.op-activity-days--header` (Check for other occurences of this class)
* [ ] **Input and select fields labels and values:** Everywhere in the app the labels and values of the input fields react differently (bold, non bold, text sizes, placeholder styles…) due to our current form implementation.
* [ ] **Invite users:** the font weights in the process are wrong.
* [ ] **Toggle buttons:** the only buttons are bold are the toggle ones.
* [ ] Decision: The Spot classes will be changed, to ensure, that no label is bold. Either, we add the `.spot-selector-field--label_regular` to the html or change it in the SPOT CSS directly
* [ ] **Input fields with placeholders:** The placeholder text has the same colour as a normal value meaning the user can differentiate it
* [ ] Decision: Take care the placeholder values are shown like before (grey and cursive)
* [ ] **My account -> Notification settings:** not bold like in the majority of the places and wrong alignment (same happens with email reminders).
**Home**
* [ ] **User customised blocks (widgets):** The texts in widgets that are customised blocks are not taking the Primer styles correctly.
* [ ] Decision: user created contend should also have the base font size of 14px (\`var(--wiki-default-font-size\`)
* [ ] **Enterprise banners:** Clearly the text size and some icons are not correctly displayed.
* [ ] Decision: see above
**Board**
* [ ] **Add new card**: Input is bold
* [ ] **Configure view**: Radio options are missing space and are bold
* [ ] Decision: `.option-label` should not be bold