Content
View differences
Updated by Henriette Darge almost 3 years ago
# Question
Do we want to merge the primer integration to the current dev and thus release it with 13.0?
## Consequences
**Advantages**
1. We could start using the components (e.g. for the new Meetings module)
2. We have more time to find and solve upcoming issues
**Disadvantages**
There are some things we are aware of that might appear "weird" to the user:
1. The font appears heavier due to it being thicker and of a deeper black
1. Labels are bold per default
2. There are inconsistencies in font sizes as the Primer default is 14px and ours is 16px
3. The The typography in general (so the styling of headlines, lists, paragraphs etc) is different.
**Note:** These issues appear because of very basic styling rules by Primer (e.g. the font-size). So we cannot solve that by a page-by-page approach.
We could weaken these differences for now by adding some overrides on our site (for example changing the font color, making labels not bold any more, etc). However, if we do that, we have to remove these overrides immediately when we start working on 13.1 so that we use the components as they are intended. This means, that we would face the same problems on the next release.
## Environment to test
[https://pr-13126-primer-dev-ip-18-195-213-39.my.pullpreview.com/](https://pr-13126-primer-dev-ip-18-195-213-39.my.pullpreview.com/)
# Decision
Yes, it will be part of 13.0 https://pr-13126-primer-dev-ip-18-195-213-39.my.pullpreview.com/
Do we want to merge the primer integration to the current dev and thus release it with 13.0?
## Consequences
**Advantages**
1. We could start using the components (e.g. for the new Meetings module)
2. We have more time to find and solve upcoming issues
**Disadvantages**
There are some things we are aware of that might appear "weird" to the user:
1. The font appears heavier due to it being thicker and of a deeper black
1. Labels are bold per default
2. There are inconsistencies in font sizes as the Primer default is 14px and ours is 16px
3. The
**Note:** These issues appear because of very basic styling rules by Primer (e.g. the font-size). So we cannot solve that by a page-by-page approach.
We could weaken these differences for now by adding some overrides on our site (for example changing the font color, making labels not bold any more, etc). However, if we do that, we have to remove these overrides immediately when we start working on 13.1 so that we use the components as they are intended. This means, that we would face the same problems on the next release.
## Environment to test
[https://pr-13126-primer-dev-ip-18-195-213-39.my.pullpreview.com/](https://pr-13126-primer-dev-ip-18-195-213-39.my.pullpreview.com/)
# Decision
Yes, it will be part of 13.0