Content
View differences
Updated by Henriette Darge 14 days ago
**Acceptance criteria**
Fix Accessibility errors detected by ERB Lint:
<br>
```text
erb_lint \`\`\`
erb\_lint -f compact . | grep GitHub
erb_lint
erb\_lint -f compact . --enable-linters git_hub/accessibility/avoid_generic_link_text,git_hub/accessibility/disabled_attribute,git_hub/accessibility/iframe_has_title,git_hub/accessibility/image_has_alt,git_hub/accessibility/link_has_href,git_hub/accessibility/navigation_has_label,git_hub/accessibility/nested_interactive_elements,git_hub/accessibility/no_aria_hidden_on_focusable,git_hub/accessibility/no_aria_label_misuse,git_hub/accessibility/no_positive_tab_index,git_hub/accessibility/no_redundant_image_alt,git_hub/accessibility/no_title_attribute,git_hub/accessibility/no_visually_hidden_interactive_elements,git_hub/accessibility/svg_has_accessible_text
```
**QA hints:** git\_hub/accessibility/avoid\_generic\_link\_text,git\_hub/accessibility/disabled\_attribute,git\_hub/accessibility/iframe\_has\_title,git\_hub/accessibility/image\_has\_alt,git\_hub/accessibility/link\_has\_href,git\_hub/accessibility/navigation\_has\_label,git\_hub/accessibility/nested\_interactive\_elements,git\_hub/accessibility/no\_aria\_hidden\_on\_focusable,git\_hub/accessibility/no\_aria\_label\_misuse,git\_hub/accessibility/no\_positive\_tab\_index,git\_hub/accessibility/no\_redundant\_image\_alt,git\_hub/accessibility/no\_title\_attribute,git\_hub/accessibility/no\_visually\_hidden\_interactive\_elements,git\_hub/accessibility/svg\_has\_accessible\_text
\`\`\`
QA hints:
Most changes are accessibility/markup fixes, so please smoke-test the touched UI areas for unchanged behavior.
Suggested areas:
\- Custom actions
- Administration → Work packages → Custom actions.
- Create/edit a custom action.
- Add and remove an action row with the close icon.
- Save and verify the workflow button behavior still works.
\- Custom fields
- Administration → Custom fields.
- Edit a list custom field with custom options.
- Reorder options using move-to-top/up/down/bottom.
- Delete an option and save.
\- Filters
- Open a page using the filter component, e.g. \`/projects\`.
- Open filters and use a list filter.
- Verify the multi-select toggle still works.
\- LDAP auth sources
- Administration → Authentication → LDAP.
- Open new/edit LDAP auth source forms.
- Verify warning banners render and can be dismissed where applicable.
\- Members form
- In a project, go to Members.
- Open the add member form, close it with the close icon.
- If user limit warnings are available in the environment, verify the warning still appears.
\- Repository pages
- Open repository checkout instructions and verify the persistent toast close/toggle behavior.
- Open a repository revision page and verify the revision input and change legend still render.
- Open the wiki syntax detailed help page and verify example links render correctly.
\- Unsupported browser warning
- If possible, force/show the unsupported browser warning.
- Verify the close control hides it and stores the dismissal.
\- Avatars
- My account → Avatar and Administration → System settings → Avatars.
- Verify Gravatar/local avatar sections still render correctly.
\- BIM
- Open a BIM project where default IFC models are still processing.
- Verify the unconverted/default model notice renders as a Primer banner.
\- Budgets / costs
- Edit planned labor/material costs in a budget.
- Verify the amount still looks link-like and opens the edit field.
- Edit a cost entry and verify planned costs can still be edited.
\- Hourly rates / cost types
- Edit user hourly rates.
- Add/delete rate rows.
- Administration → Time and costs → Cost types: add/delete rate rows.
\- 2FA flows
- OTP login form.
- Backup code login form.
- Confirm 2FA device form.
- 2FA settings and SMS/TOTP/WebAuthn device forms.
- Verify keyboard tab order is natural.
\- Webhooks
- Administration → Webhooks.
- Create/edit outgoing webhook form and verify fieldsets render.
- Open delivery logs and click “Show” response body.
- Verify the response modal opens and closes.
<br>
Fix Accessibility errors detected by ERB Lint:
<br>
```text
erb_lint
erb\_lint
erb_lint
erb\_lint
```
**QA hints:**
\`\`\`
QA hints:
Most changes are accessibility/markup fixes, so please smoke-test the touched UI areas for unchanged behavior.
Suggested areas:
\- Custom actions
- Administration → Work packages → Custom actions.
- Create/edit a custom action.
- Add and remove an action row with the close icon.
- Save and verify the workflow button behavior still works.
\- Custom fields
- Administration → Custom fields.
- Edit a list custom field with custom options.
- Reorder options using move-to-top/up/down/bottom.
- Delete an option and save.
\- Filters
- Open a page using the filter component, e.g. \`/projects\`.
- Open filters and use a list filter.
- Verify the multi-select toggle still works.
\- LDAP auth sources
- Administration → Authentication → LDAP.
- Open new/edit LDAP auth source forms.
- Verify warning banners render and can be dismissed where applicable.
\- Members form
- In a project, go to Members.
- Open the add member form, close it with the close icon.
- If user limit warnings are available in the environment, verify the warning still appears.
\- Repository pages
- Open repository checkout instructions and verify the persistent toast close/toggle behavior.
- Open a repository revision page and verify the revision input and change legend still render.
- Open the wiki syntax detailed help page and verify example links render correctly.
\- Unsupported browser warning
- If possible, force/show the unsupported browser warning.
- Verify the close control hides it and stores the dismissal.
\- Avatars
- My account → Avatar and Administration → System settings → Avatars.
- Verify Gravatar/local avatar sections still render correctly.
\- BIM
- Open a BIM project where default IFC models are still processing.
- Verify the unconverted/default model notice renders as a Primer banner.
\- Budgets / costs
- Edit planned labor/material costs in a budget.
- Verify the amount still looks link-like and opens the edit field.
- Edit a cost entry and verify planned costs can still be edited.
\- Hourly rates / cost types
- Edit user hourly rates.
- Add/delete rate rows.
- Administration → Time and costs → Cost types: add/delete rate rows.
\- 2FA flows
- OTP login form.
- Backup code login form.
- Confirm 2FA device form.
- 2FA settings and SMS/TOTP/WebAuthn device forms.
- Verify keyboard tab order is natural.
\- Webhooks
- Administration → Webhooks.
- Create/edit outgoing webhook form and verify fieldsets render.
- Open delivery logs and click “Show” response body.
- Verify the response modal opens and closes.
<br>