Content
View differences
Updated by Henriette Darge 11 months ago
# Motivation
For our goal to move closer to Primer and use those components within OpenProject, we want to primerize the app header
# Acceptance
* The app header uses Primer components for
* All menus (quick add, modules, help, User menu)
* All buttons (notifications, help (if it is a link only instead of a menu)
(Menu toggle, notifications)
* _Open: Shall the notification icon change?_
* _Open: Primer::IconButton do not support any kind of trailing counter. How shall we display the number of unread notifications? Probably has to be something custom...._
* **Open:** The search will stay an angular component but look more primerized (with rounded borders, like the autocompleteres look for example in meetings)
* The project selector will remain in angular, but the button will look primerized
selection (see below)
* The new header works with existing plugins (openDesk, Nextcloud Project, DB, ...)
* The code of the `top_menu_helper` is cleaned up
## Open
* Can we use the Primer SelectPanel for the project selection? Depends on when and to which scope the component is added to the repo by the primer team.
* Shall we just primerize what is already there, or rework the header completely
## Visuals
workPackageValue:56583:Mockups First draft: https://www.figma.com/design/uYn5FqlKTpRz1i15tG7U2j/Primer-components?node-id=0-1&t=4EPAcHqdQU1rqcy1-0
## **Out of scope**
* Do not rework the functionality of the search
* Do not change the implementation of the modules menu; will be done in <mention class="mention" data-id="65090" data-type="work_package" data-text="##65090">##65090</mention>
* Do not change the implementation of the project selector; can be done once <mention class="mention" data-id="63717" data-type="work_package" data-text="##63717">##63717</mention> is done
For our goal to move closer to Primer and use those components within OpenProject, we want to primerize the app header
# Acceptance
* The app header uses Primer components for
* All menus (quick add,
* All buttons (notifications, help (if it is a link only instead of a menu)
* _Open: Primer::IconButton do not support any kind of trailing counter. How shall we display the number of unread notifications? Probably has to be something custom...._
*
* The project selector will remain in angular, but the button will look primerized
* The code of the `top_menu_helper` is cleaned up
##
* Can we use the Primer SelectPanel for the project selection? Depends on when and to which scope the component is added to the repo by the primer team.
* Shall we just primerize what is already there, or rework the header completely
##
workPackageValue:56583:Mockups
## **Out of scope**
* Do not rework the functionality of the search
* Do not change the implementation of the modules menu; will be done in <mention class="mention" data-id="65090" data-type="work_package" data-text="##65090">##65090</mention>
* Do not change the implementation of the project selector; can be done once <mention class="mention" data-id="63717" data-type="work_package" data-text="##63717">##63717</mention> is done