Content
View differences
Updated by Cécile Guiot about 1 year ago
I noticed an additional case where we do not show the intended error message for ###61612. 61612. Reproduction is comparatively easy:
1\. Have a working setup using token \*\*exchange\*\*
2\. Misconfigure the storage to use the IDP token instead of exchanging for a token with the right audience (storage will respond with 401 on every request)
This way, when opening the files tab, we'd previously not have shown the files, but would have displayed a red error message about an HTTP 500. The error occured while fetching the remote identity, but it would even have happened if we already knew the remote identity for the user.
This PR fixes two issues:
1\. We only fetch the remote identity information, if there is no remote identity yet (causing fewer requests to storage in general, but also making reproduction harder: you need to have \*\*no\*\* remote identity)
2\. Fetch errors of the remote identity are now only logged, but do not raise an error across the \`OpenProject::Notification\` boundary. This allows the UI to show an appropriate error message.
1\. Have a working setup using token \*\*exchange\*\*
2\. Misconfigure the storage to use the IDP token instead of exchanging for a token with the right audience (storage will respond with 401 on every request)
This way, when opening the files tab, we'd previously not have shown the files, but would have displayed a red error message about an HTTP 500. The error occured while fetching the remote identity, but it would even have happened if we already knew the remote identity for the user.
This PR fixes two issues:
1\. We only fetch the remote identity information, if there is no remote identity yet (causing fewer requests to storage in general, but also making reproduction harder: you need to have \*\*no\*\* remote identity)
2\. Fetch errors of the remote identity are now only logged, but do not raise an error across the \`OpenProject::Notification\` boundary. This allows the UI to show an appropriate error message.