Content
View differences
Updated by Sagar Gurung over 1 year ago
We have different checks in our app (integration\_openproject) that get nextcloud server version and do the stuff according to the version of nextcloud version that the user is using. Foe getting the version we have used method `getVersionString()` which might lead `version_compare()` to unexpected failure. To avoid this its very safe to use `getVersion()` array version for getting the nextcloud server version.
<br>
A fix for it has been made with PR: [https://github.com/nextcloud/integration\_openproject/pull/720](https://github.com/nextcloud/integration_openproject/pull/720)
For Developers:
**TODO:**
* [ ] Add some php unit tests can be added similar to this in this file https://github.com/nextcloud/integration\_openproject/blob/eb4d3ff0f3253cf5fe77754e5f4c6207eefe49d4/tests/lib/Service/OauthSeviceTest.php#L59C18-L59C63
<br>
### For QA-Testing:
Needs Developer testing
To Be provided! test it might be little hard as you would need to either have an Nextcloud Enterprise instance to test this with or you would need to use a Nextcloud community instance and change the version string manually by adding " Enterprise" to the end of the version string in the version.php of your Nextcloud
* Test OAUTH flow between nextcloud and openproject having environment set up as:
* Nextcloud version : 29.0.7
* Integration app version: 2.7.0 (For this version it should may be fail as per this PR description [https://github.com/nextcloud/integration\_openproject/pull/719)](https://github.com/nextcloud/integration_openproject/pull/719\))
* Test OAUTH flow between nextcloud and openproject having environment set up as:
* Nextcloud version : 29.0.7
* Integration app version: checking out to `release/2.7 branch` (it should pass the oauth flow)
<br>
<br>
A fix for it has been made with PR: [https://github.com/nextcloud/integration\_openproject/pull/720](https://github.com/nextcloud/integration_openproject/pull/720)
For Developers:
**TODO:**
* [ ] Add some php unit tests can be added similar to this in this file https://github.com/nextcloud/integration\_openproject/blob/eb4d3ff0f3253cf5fe77754e5f4c6207eefe49d4/tests/lib/Service/OauthSeviceTest.php#L59C18-L59C63
<br>
### For QA-Testing:
Needs Developer testing
To Be provided!
* Nextcloud version : 29.0.7
* Integration app version: 2.7.0 (For this version it should may be fail as per this PR description [https://github.com/nextcloud/integration\_openproject/pull/719)](https://github.com/nextcloud/integration_openproject/pull/719\))
* Test OAUTH flow between nextcloud and openproject having environment set up as:
* Nextcloud version : 29.0.7
* Integration app version: checking out to `release/2.7 branch` (it should pass the oauth flow)