Content
View differences
Updated by Marcello Rocha Pereira almost 2 years ago
### Steps to reproduce
Unfortunately not yet reproducable. However,
### What is the buggy behavior?
Our code seems to delete tokens too aggressively.
* On any HTTP error
* On timeout
### What is the expected behavior?
* Only delete a token when it we know that the token is bad and not other things, such as network or maintenance mode, ...
### Environment information
Observed on community, [AppSignal indicates such events](https://appsignal.com/openproject-gmbh/sites/66b224a4d30d867bed8a1772/logs?query=Error%20while%20refreshing%20OAuth%20token.). [AppSignal logs suggest more cases](https://appsignal.com/openproject-gmbh/sites/62b06dacd2a5e41321946fcf/logs?query=Error%20while%20refreshing%20OAuth%20token.), at least on \`eu-trials3\` shard we see log messages with "Error while refreshing OAuth token."
Testing was a complex beast and was done by the developers <mention class="mention" data-id="96697" data-type="user" data-text="@Cécile Guiot">@Cécile Guiot</mention>
Unfortunately not yet reproducable. However,
### What is the buggy behavior?
Our code seems to delete tokens too aggressively.
* On any HTTP error
* On timeout
### What is the expected behavior?
* Only delete a token when it we know that the token is bad and not other things, such as network or maintenance mode, ...
### Environment information
Observed on community, [AppSignal indicates such events](https://appsignal.com/openproject-gmbh/sites/66b224a4d30d867bed8a1772/logs?query=Error%20while%20refreshing%20OAuth%20token.). [AppSignal logs suggest more cases](https://appsignal.com/openproject-gmbh/sites/62b06dacd2a5e41321946fcf/logs?query=Error%20while%20refreshing%20OAuth%20token.), at least on \`eu-trials3\` shard we see log messages with "Error while refreshing OAuth token."
Testing was a complex beast and was done by the developers <mention class="mention" data-id="96697" data-type="user" data-text="@Cécile Guiot">@Cécile Guiot</mention>