Content
View differences
Updated by Oliver Günther about 2 years ago
We currently do not have a pattern for using flash messages with primer. The meetings module went ahead in that regard and added flash messages to the top of the page, which of course exhibit a problem when scrolling (see this original bug report).
> ### Original bug report
>
> ### Steps to reproduce
>
>
1. Create or navigate to an existing dynamic meeting (as user A)
> 2. Go to an agenda item that is below the fold; i.e, you have to scroll down to get to it.
> 3. Edit the notes for that agenda item; stay in edit mode.
> 4. Log in as a different user (user B) and edit the note and save it
> 5. Now try saving the note as user A
>
>
### What is the buggy behavior?
>
>
* The error message informing the user that she can't save due to a parallel edit is not visible to the user without scrolling up to the top of the page.
> * The error message doesn't explicitly explain the problem (that the changes cannot be saved due to parallel edits).
>
>
### What is the expected behavior?
>
>
* The error message should be visible on top of the viewport (above all elements, fixed position) regardless of scroll position.
> * Change error message to:
>
* "Unable to save changes due to concurrent modifications by another user. Copy your modifications to avoid losing them and refresh the page."
>
>
### Context
>
>
* Ideally, the user never sees this error and is able to independently edit different (or even the same) parts of the page. However, this is not currently possible (known error).
>
>
### Open Questions for front-end
>
>
* Have we already replaced the OP toast with the Primer one elsewhere?
> * Are we using this error string elsewhere?
>
* Is the new string too long?
>
>
### Screenshots and other files
>
>
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/89460/content">
>
>
### Environment information
>
>
**Edge**
> **OpenProject 13.3.0**
> Core build: [fd0f24b1c615b26869c0df65494eca6df08f20df](https://github.com/opf/openproject/commits/fd0f24b1c615b26869c0df65494eca6df08f20df)
>
> [fd0f24b1c615b26869c0df65494eca6df08f20df](https://github.com/opf/openproject/commits/fd0f24b1c615b26869c0df65494eca6df08f20df)
**Browser**
>
>
* [ ] Chrome
> * [x] Firefox
> * [ ] Safari
> * [ ] Mobile Safari
> * [ ] Other (please specify)
>
>
**Language**
>
>
_EN_
> ### Original bug report
>
> ### Steps to reproduce
>
>
> 2. Go to an agenda item that is below the fold; i.e, you have to scroll down to get to it.
> 3. Edit the notes for that agenda item; stay in edit mode.
> 4. Log in as a different user (user B) and edit the note and save it
> 5. Now try saving the note as user A
>
>
>
>
> * The error message doesn't explicitly explain the problem (that the changes cannot be saved due to parallel edits).
>
>
>
>
> * Change error message to:
>
>
>
>
>
>
>
>
>
> * Are we using this error string elsewhere?
>
>
>
>
>
>
>
>
>
> **OpenProject 13.3.0**
> Core build: [fd0f24b1c615b26869c0df65494eca6df08f20df](https://github.com/opf/openproject/commits/fd0f24b1c615b26869c0df65494eca6df08f20df)
>
>
>
>
> * [x] Firefox
> * [ ] Safari
> * [ ] Mobile Safari
> * [ ] Other (please specify)
>
>
>
>