Content
View differences
Updated by Behrokh Satarnejad almost 3 years ago
# Issues
* [x] **Font prominence:** Reduce all font sizes 16px to 14px (Primer approach) or override with a font smoothing.
* [x] Decisions: We try 14px. If we see it's too much work, we can still switch to the override
* [x] **Filter box and input fields:** Primer input fields are transparent. Therefore inside of the filter box they appear grey.
* [x] Decisions: We propose to remove the box background in accordance to most of the boxes in Primer.
* [x] **Flashes:** Links in flashes are not highlighted as links
* [x] Decisison: Show links as links again (For example, new LDAP connection page)
* [x] **Buttons in Toolbar actions and spot action bar:** some of the buttons have an underline hover.
* [x] Decision: Since it is too much work to replace all links with actual button tags, we will override the hover effect very specificly (`.toolbar a.button`)
* [x] **Headers space:** after removing divider from the activity as they don’t use divider for headers some places have no spacing bellow.
* [x] Decision: No generic decision, needs to be decided case by case
* [x] [ ] **Enterprise banners:** they are broken in spacings and sizes.
* [x] [ ] Decision: There went something wrong with the html strucutre. Only the header should be bigger (20px), the rest should be 14px. Also the icons (e.g of the "more information" link should be smaller)
* [x] **News headers and body text:** reduce the size of this texts to make it less prominent.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x] **Roadmap spacings:** the space between one version and the next one seams to be reduced now that we don’t have a divider.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x] **User activity:** the page is difficult to read by itself but now without dividers is even worst.
* [x] Decision: Remove custom styles of class `.op-activity-days--header` (Check for other occurences of this class)
* [x] **Input and select fields labels and values:** Everywhere in the app the labels and values of the input fields react differently (bold, non bold, text sizes, placeholder styles…) due to our current form implementation.
* [x] **Invite users:** the font weights in the process are wrong.
* [x] **Toggle buttons:** the only buttons are bold are the toggle ones.
* [x] Decision: The Spot classes will be changed, to ensure, that no label is bold. Either, we add the `.spot-selector-field--label_regular` to the html or change it in the SPOT CSS directly
* [x] **Input fields with placeholders:** The placeholder text has the same colour as a normal value meaning the user can differentiate it
* [x] Decision: Take care the placeholder values are shown like before (grey)
* [x] **My account -> Notification settings:** not bold like in the majority of the places and wrong alignment (same happens with email reminders).
* [x] Decision: Make the labels bold, as primer does it. Fix alignment
* [ ] **Top bar:** 'Select a project' text on project selection modal is cut from bottom in Chrome
* [ ] Decision: Nothing should be cut off
**Home**
* [x] **User customised blocks (widgets):** The texts in widgets that are customised blocks are not taking the Primer styles correctly.
* [x] Decision: user created contend should also have the base font size of 14px (\`var(--wiki-default-font-size\`)
* [x] [ ] **Enterprise banners:** Clearly the text size and some icons are not correctly displayed.
* [x] [ ] Decision: see above
**Board**
* [x] **Add new card**: Input is bold
* [x] Decision: Should not be bold
* [x] **Configure view**: Radio options are missing space and are bold
* [x] Decision: `.option-label` should not be bold
* [x] **Font prominence:** Reduce all font sizes 16px to 14px (Primer approach) or override with a font smoothing.
* [x] Decisions: We try 14px. If we see it's too much work, we can still switch to the override
* [x] **Filter box and input fields:** Primer input fields are transparent. Therefore inside of the filter box they appear grey.
* [x] Decisions: We propose to remove the box background in accordance to most of the boxes in Primer.
* [x] **Flashes:** Links in flashes are not highlighted as links
* [x] Decisison: Show links as links again (For example, new LDAP connection page)
* [x] **Buttons in Toolbar actions and spot action bar:** some of the buttons have an underline hover.
* [x] Decision: Since it is too much work to replace all links with actual button tags, we will override the hover effect very specificly (`.toolbar a.button`)
* [x] **Headers space:** after removing divider from the activity as they don’t use divider for headers some places have no spacing bellow.
* [x] Decision: No generic decision, needs to be decided case by case
* [x]
* [x]
* [x] **News headers and body text:** reduce the size of this texts to make it less prominent.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x] **Roadmap spacings:** the space between one version and the next one seams to be reduced now that we don’t have a divider.
* [x] Decision: Ignore that, as the whole page needs a redesign
* [x] **User activity:** the page is difficult to read by itself but now without dividers is even worst.
* [x] Decision: Remove custom styles of class `.op-activity-days--header` (Check for other occurences of this class)
* [x] **Input and select fields labels and values:** Everywhere in the app the labels and values of the input fields react differently (bold, non bold, text sizes, placeholder styles…) due to our current form implementation.
* [x] **Invite users:** the font weights in the process are wrong.
* [x] **Toggle buttons:** the only buttons are bold are the toggle ones.
* [x] Decision: The Spot classes will be changed, to ensure, that no label is bold. Either, we add the `.spot-selector-field--label_regular` to the html or change it in the SPOT CSS directly
* [x] **Input fields with placeholders:** The placeholder text has the same colour as a normal value meaning the user can differentiate it
* [x] Decision: Take care the placeholder values are shown like before (grey)
* [x] **My account -> Notification settings:** not bold like in the majority of the places and wrong alignment (same happens with email reminders).
* [x] Decision: Make the labels bold, as primer does it. Fix alignment
* [ ] **Top bar:** 'Select a project' text on project selection modal is cut from bottom in Chrome
* [ ] Decision: Nothing should be cut off
**Home**
* [x] **User customised blocks (widgets):** The texts in widgets that are customised blocks are not taking the Primer styles correctly.
* [x] Decision: user created contend should also have the base font size of 14px (\`var(--wiki-default-font-size\`)
* [x]
* [x]
**Board**
* [x] **Add new card**: Input is bold
* [x] Decision: Should not be bold
* [x] **Configure view**: Radio options are missing space and are bold
* [x] Decision: `.option-label` should not be bold