Content
View differences
Updated by Carsten Klein over 9 years ago
Version: dev
The include macro checks for user being permitted to view wiki pages.
In this context, however, the included wiki page stems from the same project/wiki. Subsequently, and while this check is redundant in this specific case, it adds approx. 1000ms to the overall request processing time in my development environment for a very simple page.
Removing that check adds very little to the overall response time. (\<1ms for the same page)
I guess guarding the permission check with page.wiki.project wikipage.project == options\[:project\] would suffice to make it fast for the standard use case. The rest will require further optimization on the authorization path, though.
The include macro checks for user being permitted to view wiki pages.
In this context, however, the included wiki page stems from the same project/wiki. Subsequently, and while this check is redundant in this specific case, it adds approx. 1000ms to the overall request processing time in my development environment for a very simple page.
Removing that check adds very little to the overall response time. (\<1ms for the same page)
I guess guarding the permission check with page.wiki.project