Content
View differences
Updated by Alexander Coles 6 days ago
Bump `@hotwired/turbo` and `@hotwired/turbo-rails` from 8.0.20 to 8.0.23.
* Replace generic `CustomEvent` handling and ad-hoc interface definitions with typed Turbo events from `@types/hotwired__turbo` 8.0.9, removing eslint-disable suppressions and unnecessary casts.
* Add compile-time exhaustiveness guard for Turbo event names.
* Use ProgressBar API directly instead of faking FormSubmission arguments.
* Fix canceled work package edit Back navigation and query history filter pane regression surfaced by the upgrade.
### Hints for QA
Manual QA should focus on smoke testing leave/navigation behaviour around editable work package forms (which is where Angular and Turbo interact).
The most critical check is that there is no double prompt on closing a browser/navigating away while editing work package forms.
**Specific checks (time/resource permitting):**
1. **Work package full page edit**
* Edit a field, navigate via logo/sidebar.
* Cancel prompt: stay put, edit state remains.
* Accept prompt: leave cleanly.
2. **Work package split view / table navigation**
* Open WP in split view, edit a field, click another WP or leave the page.
* Warning appears when changes would be lost.
* Cancel keeps the current split view usable.
3. **New work package form**
* Start creating a WP, change fields, navigate away.
* Warning appears.
* Accept leaves without stale create/edit state.
4. **Focused but unchanged field**
* Click into an editable WP field but do not type.
* Navigate away.
* Confirm the prompt behaviour feels OK here.
5. **Save / cancel paths**
* Edit and save, then navigate away: no warning.
* Edit and use the form cancel action, then navigate away: no warning.
6. **Non-Angular / Rails pageState form**
* Edit a meeting agenda item.
* Navigate away and confirm the existing Stimulus/pageState warning still appears.
* Save/cancel the agenda edit and confirm navigation no longer warns.
<br>
* Replace generic `CustomEvent` handling and ad-hoc interface definitions with typed Turbo events from `@types/hotwired__turbo` 8.0.9, removing eslint-disable suppressions and unnecessary casts.
* Add compile-time exhaustiveness guard for Turbo event names.
* Use ProgressBar API directly instead of faking FormSubmission arguments.
* Fix canceled work package edit Back navigation and query history filter pane regression surfaced by the upgrade.
### Hints for QA
Manual QA should focus on smoke testing leave/navigation behaviour around editable work package forms (which is where Angular and Turbo interact).
The most critical check is that there is no double prompt on closing a browser/navigating away while editing work package forms.
**Specific checks (time/resource permitting):**
1. **Work package full page edit**
* Edit a field, navigate via logo/sidebar.
* Cancel prompt: stay put, edit state remains.
* Accept prompt: leave cleanly.
2. **Work package split view / table navigation**
* Open WP in split view, edit a field, click another WP or leave the page.
* Warning appears when changes would be lost.
* Cancel keeps the current split view usable.
3. **New work package form**
* Start creating a WP, change fields, navigate away.
* Warning appears.
* Accept leaves without stale create/edit state.
4. **Focused but unchanged field**
* Click into an editable WP field but do not type.
* Navigate away.
* Confirm the prompt behaviour feels OK here.
5. **Save / cancel paths**
* Edit and save, then navigate away: no warning.
* Edit and use the form cancel action, then navigate away: no warning.
6. **Non-Angular / Rails pageState form**
* Edit a meeting agenda item.
* Navigate away and confirm the existing Stimulus/pageState warning still appears.
* Save/cancel the agenda edit and confirm navigation no longer warns.
<br>