Content
View differences
Updated by Christophe Bliard 3 months ago
### Steps to reproduce
1. Go to User menu -> Account settings -> Access tokens, and scroll to OAuth section
2. Get some OAuth tokens here (I have no idea how to have one. Luckily I have one for Documents on qa stage. If you know please update the reproduction steps)
3. Click on delete button
1. a confirmation modal opens
### What is the buggy behavior?
* The text is wrong and repeats "tokens" twice "tokens twice"
* en: "This will revoke 9 active token active for it.". One extra active
* fr: "Ceci va révoquer un jeton actif 9 actif pour elle.". One extra "actif"
* de: "Dies wird 9 aktive Token aktive Token widerrufen." One extra "aktive Token"
* see screenshot
* It's hard to translate because it trumps translators expectations (I was actually fixing some translations for French language, and that's how I stumbled upon this one)
* BTW, in the row, active tokens is 0, but when trying to delete it, it shows 9? Shouldn't it be the same? What is the difference?
### What is the expected behavior?
1. Clear message
2. Easy translation
1. I mean, the translation is built up with 2 translations (`t("oauth.revoke_my_application_confirmation", token_count: t("oauth.x_active_tokens", count:))`).
<br>
Are we sure it's ok for all languages to build up sentences like this?
<br>
Wouldn't it be simpler to only have one with a `%{count}` like `t("oauth.revoke_my_application_confirmation", count:)`, this means more translation work but also less coupling and more accurate translations in case grammar rules for some languages do not allow it
###
###
### Screenshots and other files
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919652/content">
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919653/content">
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919651/content">
<br>
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919650/content">
### Environment information
**OpenProject version**
17.2
**Language**
Tested with English, French, and German. Probably invalid in a lot of other languages.
1. Go to User menu -> Account settings -> Access tokens, and scroll to OAuth section
2. Get some OAuth tokens here (I have no idea how to have one. Luckily I have one for Documents on qa stage. If you know please update the reproduction steps)
3. Click on delete button
1. a confirmation modal opens
### What is the buggy behavior?
* The text is wrong and repeats "tokens" twice
* en: "This will revoke 9 active token active for it.". One extra active
* fr: "Ceci va révoquer un jeton actif 9 actif pour elle.". One extra "actif"
* de: "Dies wird 9 aktive Token aktive Token widerrufen." One extra "aktive Token"
* see screenshot
* It's hard to translate because it trumps translators expectations (I was actually fixing some translations for French language, and that's how I stumbled upon this one)
* BTW, in the row, active tokens is 0, but when trying to delete it, it shows 9? Shouldn't it be the same? What is the difference?
### What is the expected behavior?
1. Clear message
2. Easy translation
1. I mean, the translation is built up with 2 translations (`t("oauth.revoke_my_application_confirmation", token_count: t("oauth.x_active_tokens", count:))`).
<br>
<br>
###
###
### Screenshots and other files
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919652/content">
<br>
<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/919650/content">
### Environment information
**OpenProject version**
17.2
**Language**
Tested with English, French, and German. Probably invalid in a lot of other languages.