Content
View differences
Updated by Ivan Kuchin 22 days ago
* [x] [ ] Tests:
* [x] Feature tests for project overview (modules/overviews/app/components/overviews/project\_custom\_fields/\* + modules/overviews/app/controllers/overviews/project\_custom\_fields\_controller.rb)
* [x] Test remembering custom comment when editing custom value through modal and getting a validation error
* [x] Test remembering custom comment when editing custom value in PIR
* [x] app/models/custom\_field.rb : test can\_have\_comment? and comment\_for
* [x] [ ] lib\_static/plugins/acts\_as\_customizable/lib/acts\_as\_customizable.rb - tested implicitly, but better to test expected behaviour for project as having comment and work package as not having them
* [x] API docs for the newly introduced custom comment fields
* [x] Decide if custom comments functionality should stay in acts as customizable or be moved to Projects::CustomFields
* We decided during a meeting that custom comments are desired in fields of other customizable objects, so should stay in acts\_as\_customizable, even so there is no plan defined for enabling them for other customizable objects
* [x] ~~N+1 [ ] N+1 when exporting project query is still present:~~ [~~https://github.com/opf/openproject/pull/21452#discussion\_r2853944639~~](https://github.com/opf/openproject/pull/21452#discussion_r2853944639)
* <mention class="mention" data-id="72880" data-type="work_package" data-text="##72880">##72880</mention> present: https://github.com/opf/openproject/pull/21452#discussion\_r2853944639
* [x] Feature tests for project overview (modules/overviews/app/components/overviews/project\_custom\_fields/\* + modules/overviews/app/controllers/overviews/project\_custom\_fields\_controller.rb)
* [x] Test remembering custom comment when editing custom value through modal and getting a validation error
* [x] Test remembering custom comment when editing custom value in PIR
* [x] app/models/custom\_field.rb : test can\_have\_comment? and comment\_for
* [x]
* [x] API docs for the newly introduced custom comment fields
* [x] Decide if custom comments functionality should stay in acts as customizable or be moved to Projects::CustomFields
* We decided during a meeting that custom comments are desired in fields of other customizable objects, so should stay in acts\_as\_customizable, even so there is no plan defined for enabling them for other customizable objects
* [x] ~~N+1
* <mention class="mention" data-id="72880" data-type="work_package" data-text="##72880">##72880</mention>