Content
View differences
Updated by Alexander Coles 6 months ago
### Steps to reproduce
1. Login as a user with permissions to administer OpenProject
2. Go to _Administration_ > _Users and permissions_ > _Roles and permissions_
3. Click on an existing role in the table or click "+ Role" to create a new role
4. To the right of a collapsible section header, click "Check all" or "Uncheck all"
### What is the buggy behavior?
* The collapsible section is toggled: if it was opened, it is closed. If it was closed, it is now open.
### What is the expected behavior?
1. The collapsible section should not be toggled - (_OR - for discussion, should always be opened?)_
### Hints for QA
Also reproducible on:
* _Administation > Users and permissions > Permissions report_
The fix includes a reimplementation of "check all" functionality globally, so in addition to checking the bug is no longer reproducible, it would also be good to double check the following screens that show "check all" buttons but without collapsible sections:
* _Administration > Work packages > Workflow_ (N.B. the "check all" buttons are truncated - however this appears to be an existing issue).
* _Administration > API and webhooks > Webhooks > Webhook name_ (under Enabled Events)
The reimplementation includes some accessibility improvements:
* Tooltip text on the Permissions report table now shows "Check all/Uncheck all in row", "Check all/Uncheck all in column".
* `aria-controls` attribute is applied to "Check all"/"Uncheck all" buttons when they are not descendants of a fieldset/checkbox group container (in plain English: a different part of the page hierarchy). This is the case for collapsible sections. `aria-controls` indicates a causal relationship between buttons and the checkboxes.
There is also a small styling change on the Permissions report page - we use a label rather than italics to indicate "built in" roles. _(An FYI has been added to the UX/UI meeting agenda:_ [_https://community.openproject.org/meetings/7628#meeting-agenda-item-21490_](https://community.openproject.org/meetings/7628#meeting-agenda-item-21490) _)_
### Environment information
**OpenProject installation type**
* Hosted cloud edition
**OpenProject version**
**Core build**
[5749b434e01b71117c9f97b5421060d127600ea6](https://github.com/opf/openproject/commits/5749b434e01b71117c9f97b5421060d127600ea6)
**Product version**
[89661f5c04938c6a56815503e2b43f5d87e782c4](https://github.com/opf/saas-openproject/commits/89661f5c04938c6a56815503e2b43f5d87e782c4)
**Core version**
OpenProject 17.0.0
**Browser**
* [x] Chrome
* [ ] Firefox
* [ ] Safari
* [ ] Mobile Safari
* [ ] Other (please specify)
**Operating System**
* [ ] Windows
* [x] Mac OS X
* [ ] Mobile iOS
* [ ] Mobile Android
* [ ] Linux (please specify distro)
* [ ] Chrome OS
* [ ] Other (please specify)
**Language**
_en\_GB_
1. Login as a user with permissions to administer OpenProject
2. Go to _Administration_ > _Users and permissions_ > _Roles and permissions_
3. Click on an existing role in the table or click "+ Role" to create a new role
4. To the right of a collapsible section header, click "Check all" or "Uncheck all"
### What is the buggy behavior?
* The collapsible section is toggled: if it was opened, it is closed. If it was closed, it is now open.
### What is the expected behavior?
1. The collapsible section should not be toggled - (_OR - for discussion, should always be opened?)_
### Hints for QA
Also reproducible on:
* _Administation > Users and permissions > Permissions report_
The fix includes a reimplementation of "check all" functionality globally, so in addition to checking the bug is no longer reproducible, it would also be good to double check the following screens that show "check all" buttons but without collapsible sections:
* _Administration > Work packages > Workflow_ (N.B. the "check all" buttons are truncated - however this appears to be an existing issue).
* _Administration > API and webhooks > Webhooks > Webhook name_ (under Enabled Events)
The reimplementation includes some accessibility improvements:
* Tooltip text on the Permissions report table now shows "Check all/Uncheck all in row", "Check all/Uncheck all in column".
* `aria-controls` attribute is applied to "Check all"/"Uncheck all" buttons when they are not descendants of a fieldset/checkbox group container (in plain English: a different part of the page hierarchy). This is the case for collapsible sections. `aria-controls` indicates a causal relationship between buttons and the checkboxes.
There is also a small styling change on the Permissions report page - we use a label rather than italics to indicate "built in" roles. _(An FYI has been added to the UX/UI meeting agenda:_ [_https://community.openproject.org/meetings/7628#meeting-agenda-item-21490_](https://community.openproject.org/meetings/7628#meeting-agenda-item-21490) _)_
### Environment information
**OpenProject installation type**
* Hosted cloud edition
**OpenProject version**
**Core build**
[5749b434e01b71117c9f97b5421060d127600ea6](https://github.com/opf/openproject/commits/5749b434e01b71117c9f97b5421060d127600ea6)
**Product version**
[89661f5c04938c6a56815503e2b43f5d87e782c4](https://github.com/opf/saas-openproject/commits/89661f5c04938c6a56815503e2b43f5d87e782c4)
**Core version**
OpenProject 17.0.0
**Browser**
* [x] Chrome
* [ ] Firefox
* [ ] Safari
* [ ] Mobile Safari
* [ ] Other (please specify)
**Operating System**
* [ ] Windows
* [x] Mac OS X
* [ ] Mobile iOS
* [ ] Mobile Android
* [ ] Linux (please specify distro)
* [ ] Chrome OS
* [ ] Other (please specify)
**Language**
_en\_GB_