Content
View differences
Updated by Deleted user almost 11 years ago
*Description copied from \#14507*
filling this with useful information:
- we have a monkey patch for awesome\_nested\_set with is fixed in the 2.1 branch of awesome\_nested\_net
- but, that version is not released (probably too old)
- we could use awesome\_nested\_net 3.0 and above, the fix is in there, too (probably needs some work in OP, too)
- PR seems fine if we want to use an unrelased git branch of awesome\_nested\_set
BUT
- completely not understandable, the PR also removes Gemfile.lock (while not pinning all versions in the Gemfile, which would be somewhat understandable)
- nevertheless, this is a huge change and shouldn’t be in a PR like this.
- therefore PR got closed (for an uncountable number of times now :-( )
see https://github.com/opf/openproject/pull/2059/files for details
DISCLAIMER: this description is written by a OP team member, not the original author of the ticket
filling this with useful information:
- we have a monkey patch for awesome\_nested\_set with is fixed in the 2.1 branch of awesome\_nested\_net
- but, that version is not released (probably too old)
- we could use awesome\_nested\_net 3.0 and above, the fix is in there, too (probably needs some work in OP, too)
- PR seems fine if we want to use an unrelased git branch of awesome\_nested\_set
BUT
- completely not understandable, the PR also removes Gemfile.lock (while not pinning all versions in the Gemfile, which would be somewhat understandable)
- nevertheless, this is a huge change and shouldn’t be in a PR like this.
- therefore PR got closed (for an uncountable number of times now :-( )
see https://github.com/opf/openproject/pull/2059/files for details
DISCLAIMER: this description is written by a OP team member, not the original author of the ticket