# Bug SPAR-89 - Progress modal should always prevent save when there are invalid values

Project: Stream Planning and Reporting
Status: closed
URL: https://community.openproject.org/work_packages/SPAR-89

## Open points

_No work packages_

## Details

| Attribute | Value |
| --- | --- |
| Date |  |
| Priority | Medium |
| Module |  |
| Target versions | 14.6.0 |
| Observed in versions | 14.4.0 |
| Bug found in version (deprecated) | 14.4.x |
| Requires doc change | No |
| Accessibility | No |
| Pull preview |  |
| List |  |
| Labels |  |

## People

| Attribute | Value |
| --- | --- |
| Assignee |  |
| Accountable | Christophe Bliard |
| Product manager |  |
| Developers |  |
| Designer |  |
| Ordered by |  |
| Signed off by |  |
| Interest by |  |

## Planning

| Attribute | Value |
| --- | --- |
| Relevance |  |

## Costs

| Attribute | Value |
| --- | --- |
| Votes |  |
| Work |  |
| Labor costs |  |

## Description

### Steps to reproduce

1.  On a work package, click on the work field to open the progress popover
    
2.  Enter an invalid value (&quot;asdf&quot;, &quot;-5&quot;, etc...)
    
3.  Click Save button once
    
    1.  The save action is prevented
        
4.  Click Save a second time (or sometimes a third time)
    

### What is the buggy behavior?

*   The progress popover is closed and a message &quot;Successful update.&quot; is displayed
    
*   Actually, nothing has been saved and the invalid values are not pertained, but it makes the user think the invalid values have been saved
    
*   It also works with pressing &quot;Enter&quot; key twice instead of clicking &quot;Save&quot; button twice
    

### What is the expected behavior?

1.  The progress popover should remain open
    
2.  The Save button should not submit the values and close the modal until the values are valid
    

### Screenshots and other files

Here is a GIF demonstrating the issue (I had to click 3 times this time)

<img class="op-uc-image op-uc-image_inline" src="/api/v3/attachments/181464/content">

### Environment information

**OpenProject installation type**

*   [x] Hosted cloud edition
*   [ ] Packaged installation
    *   What distribution?
        
*   [ ] Docker All-in-one container
*   [ ] Docker-compose installation
*   [ ] Other (please specify)

**OpenProject version**

14.4.1

_Tested on current stage 14.4.1.eb98b082a05457311837ab57e96709574c3e8cf5_

_Probably existed for a longer time_

**Browser**

*   [x] Chrome
*   [x] Firefox
*   [ ] Safari
*   [ ] Mobile Safari
*   [ ] Other (please specify)
