# Bug OP-18641 - NoMethodError in Storages::Admin::AccessManagementController#update 

Project: OpenProject
Status: closed
URL: https://community.openproject.org/work_packages/OP-18641

## Open points

_No work packages_

## Details

| Attribute | Value |
| --- | --- |
| Date |  |
| Priority | Medium |
| Module | Integrations / SharePoint/OneDrive |
| Target versions | 17.0.1 |
| Observed in versions | 17.0.0 |
| Sprint | 17.0.1 |
| Backlog bucket |  |
| Bug found in version (deprecated) | 17.0.x |
| Found in mobile app version |  |
| Follow-up feedback e-mail |  |
| Requires doc change | No |
| Accessibility | No |
| Pull preview |  |
| List |  |
| Labels |  |

## People

| Attribute | Value |
| --- | --- |
| Assignee |  |
| Accountable |  |
| Product manager |  |
| Developers | OP Dev Titan Team |
| Designer |  |
| Ordered by |  |
| Signed off by |  |
| Interest by |  |

## Planning

| Attribute | Value |
| --- | --- |
| Relevance |  |

## Costs

| Attribute | Value |
| --- | --- |
| Votes |  |
| Work |  |
| Labor costs |  |

## Description

### Steps to reproduce

1.  Unclear - AppSignal report
    

### What is the buggy behavior?

Unclear - AppSignal report

### What is the expected behavior?

_Unclear - AppSignal report_

### **Logs**

```text
undefined method 'add_error' for an instance of ServiceResult

modules/storages/app/services/storages/storages/update_service.rb:54 Storages::Storages::UpdateService#handle_sharepoint_storage

modules/storages/app/services/storages/storages/update_service.rb:38 Storages::Storages::UpdateService#after_validate

app/services/base_services/base_contracted.rb:65 block in BaseServices::BaseContracted#perform

app/models/journal/notification_configuration.rb:42 Journal::NotificationConfiguration.with

app/services/shared/service_context.rb:69 block in Shared::ServiceContext#without_context_transaction

lib/open_project/locale_helper.rb:36 OpenProject::LocaleHelper.with_locale_for

app/models/user.rb:542 User.execute_as

app/services/shared/service_context.rb:68 Shared::ServiceContext#without_context_transaction

app/services/shared/service_context.rb:47 block in Shared::ServiceContext#in_mutex_context

lib/open_project/mutex.rb:71 block in OpenProject::Mutex.with_advisory_lock

lib/open_project/mutex.rb:69 OpenProject::Mutex.with_advisory_lock

vendor/plugins/openproject-multitenancy/app/extenders/lib/open_project/namespaced_advisory_lock_names.rb:4 Multitenancy::NamespacedAdvisoryLockNames#with_advisory_lock

lib/open_project/mutex.rb:63 block in OpenProject::Mutex.with_advisory_lock_transaction

lib/open_project/mutex.rb:62 OpenProject::Mutex.with_advisory_lock_transaction

app/services/shared/service_context.rb:46 Shared::ServiceContext#in_mutex_context

app/services/shared/service_context.rb:37 Shared::ServiceContext#in_context

app/services/base_services/base_contracted.rb:56 BaseServices::BaseContracted#service_context

app/services/base_services/base_contracted.rb:61 BaseServices::BaseContracted#perform

app/services/base_services/base_callable.rb:42 block in BaseServices::BaseCallable#call

app/services/base_services/base_callable.rb:70 BaseServices::BaseCallable#assign_state

app/services/base_services/base_callable.rb:41 BaseServices::BaseCallable#call
```

Params:

```text
{
  "_method": "patch",
  "action": "update",
  "authenticity_token": "[FILTERED]",
  "controller": "storages/admin/access_management",
  "storage_id": "83",
  "storages_sharepoint_storage": {
    "automatic_management_enabled": "true"
  },
  "submit": "Save and continue"
}
```

[https://appsignal.com/openproject-gmbh/sites/678fa146338a5d816f8d696c/exceptions/incidents/1201](https://appsignal.com/openproject-gmbh/sites/678fa146338a5d816f8d696c/exceptions/incidents/1201)

https://appsignal.com/openproject-gmbh/sites/678fa146338a5d816f8d696c/exceptions/incidents/1068
