# Bug OP-15717 - Migration 20230608151123_add_validity_period_to_journals is very slow

Project: OpenProject
Status: closed
URL: https://community.openproject.org/work_packages/OP-15717

## Open points

_No work packages_

## Details

| Attribute | Value |
| --- | --- |
| Date |  |
| Priority | High |
| Module |  |
| Target versions | 15.0.0 |
| Observed in versions | 14.4.0 |
| Sprint | 15.0.0 |
| Backlog bucket |  |
| Bug found in version (deprecated) | 14.4.x |
| Found in mobile app version |  |
| Follow-up feedback e-mail |  |
| Requires doc change | No |
| Accessibility | No |
| Pull preview |  |
| List |  |
| Labels |  |

## People

| Attribute | Value |
| --- | --- |
| Assignee |  |
| Accountable | Jens Ulferts |
| Product manager |  |
| Developers |  |
| Designer |  |
| Ordered by |  |
| Signed off by |  |
| Interest by |  |

## Planning

| Attribute | Value |
| --- | --- |
| Relevance |  |

## Costs

| Attribute | Value |
| --- | --- |
| Votes |  |
| Work |  |
| Labor costs |  |

## Description

### Steps to reproduce

_Please write down the steps to reproduce. Try to write down all necessary preconditions (what permissions do you have, are other users involved?). Example:_

1.  Perform an upgrade from 12.4.0 to 14.4.0
    
2.  Depending on the amount of journals, the migration takes more than a week to run&nbsp;
    

### What is the buggy behavior?

_Please describe the bug in as much detail as possible. Example:_

*   The migration is too slow
    
      
    

### What is the expected behavior?

_Describe how the application should behave like. Example:_

1.  The migration should not take too long 
    
      
    

### Important note

  

The biggest problems seemed to be the following queries:

```sql
-- select_rows("UPDATE journals SET created_at = LEAST(journals.created_at, successors.created_at - interval '1 ms'), updated_at = CASE WHEN journals.created_at = journals.updated_at THEN LEAST(journals.created_at, successors.created_at - interval '1 ms') ELSE journals.updated_at END FROM ( SELECT predecessors.id, successors.created_at FROM journals predecessors LEFT JOIN LATERAL (SELECT DISTINCT ON (journable_type, journable_id) * FROM journals successors WHERE successors.version > predecessors.version AND successors.journable_id = predecessors.journable_id AND successors.journable_type = predecessors.journable_type AND successors.created_at <= predecessors.created_at ORDER BY successors.journable_type ASC, successors.journable_id ASC, successors.version ASC) successors ON successors.journable_id = predecessors.journable_id AND successors.journable_type = predecessors.journable_type ) successors WHERE successors.id = journals.id AND successors.created_at <= journals.created_at RETURNING journals.journable_id")
```

and

```sql
-- execute("UPDATE journals SET validity_period = values.validity_period FROM ( SELECT predecessors.id, tstzrange(predecessors.created_at, successors.created_at) validity_period FROM journals predecessors LEFT JOIN LATERAL (SELECT DISTINCT ON (journable_type, journable_id) * FROM journals successors WHERE successors.version > predecessors.version AND successors.journable_id = predecessors.journable_id ORDER BY successors.journable_type ASC, successors.journable_id ASC, successors.version ASC) successors ON successors.journable_id = predecessors.journable_id AND successors.journable_type = predecessors.journable_type ) values WHERE values.id = journals.id")
```

###
